Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, bemjb+rendering_chromium.org, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, kenneth.christiansen, nessy, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, vcarbune.chromium, gavinp+prerender_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, gasubic, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make sure getAttribute() / setAttribute() callers use AtomicStrings Make sure getAttribute() / setAttribute() callers use AtomicStrings. Especially, the DOM API should make sure to request an AtomicString if they call setAttribute() internally so that the bindings code won't uselessly created a WTF::String from the v8::String. That String will then implicitly be converted to an AtomicString when calling setAttribute(), which has a cost. This is one step towards making the AtomicString(const String&) constructor explicit. R=abarth, eseidel, haraken BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -157 lines) Patch
M Source/core/dom/Document.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 2 chunks +11 lines, -10 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAudioElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAudioElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 2 chunks +5 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMetaElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLParamElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLParamElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableColElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTrackElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/LinkResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years ago (2013-12-05 15:52:54 UTC) #1
philipj_slow
non-owner yay and lgtm for HTML{Audio,Media,Track}Element
7 years ago (2013-12-05 20:10:49 UTC) #2
eseidel
lgtm
7 years ago (2013-12-05 21:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/99333011/1
7 years ago (2013-12-05 21:06:01 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-06 01:44:36 UTC) #5
Message was sent while issue was closed.
Change committed as 163293

Powered by Google App Engine
This is Rietveld 408576698