Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/core/html/track/TextTrack.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/HiddenInputType.cpp ('k') | Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 public: 57 public:
58 static PassRefPtr<TextTrack> create(Document& document, TextTrackClient* cli ent, const AtomicString& kind, const AtomicString& label, const AtomicString& la nguage) 58 static PassRefPtr<TextTrack> create(Document& document, TextTrackClient* cli ent, const AtomicString& kind, const AtomicString& label, const AtomicString& la nguage)
59 { 59 {
60 return adoptRef(new TextTrack(document, client, kind, label, language, e mptyAtom, AddTrack)); 60 return adoptRef(new TextTrack(document, client, kind, label, language, e mptyAtom, AddTrack));
61 } 61 }
62 virtual ~TextTrack(); 62 virtual ~TextTrack();
63 63
64 void setMediaElement(HTMLMediaElement* element) { m_mediaElement = element; } 64 void setMediaElement(HTMLMediaElement* element) { m_mediaElement = element; }
65 HTMLMediaElement* mediaElement() { return m_mediaElement; } 65 HTMLMediaElement* mediaElement() { return m_mediaElement; }
66 66
67 AtomicString kind() const { return m_kind; } 67 const AtomicString& kind() const { return m_kind; }
68 void setKind(const AtomicString&); 68 void setKind(const AtomicString&);
69 69
70 static const AtomicString& subtitlesKeyword(); 70 static const AtomicString& subtitlesKeyword();
71 static const AtomicString& captionsKeyword(); 71 static const AtomicString& captionsKeyword();
72 static const AtomicString& descriptionsKeyword(); 72 static const AtomicString& descriptionsKeyword();
73 static const AtomicString& chaptersKeyword(); 73 static const AtomicString& chaptersKeyword();
74 static const AtomicString& metadataKeyword(); 74 static const AtomicString& metadataKeyword();
75 static bool isValidKindKeyword(const AtomicString&); 75 static bool isValidKindKeyword(const AtomicString&);
76 76
77 AtomicString label() const { return m_label; } 77 AtomicString label() const { return m_label; }
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 TextTrackType m_trackType; 159 TextTrackType m_trackType;
160 ReadinessState m_readinessState; 160 ReadinessState m_readinessState;
161 int m_trackIndex; 161 int m_trackIndex;
162 int m_renderedTrackIndex; 162 int m_renderedTrackIndex;
163 bool m_hasBeenConfigured; 163 bool m_hasBeenConfigured;
164 }; 164 };
165 165
166 } // namespace WebCore 166 } // namespace WebCore
167 167
168 #endif 168 #endif
OLDNEW
« no previous file with comments | « Source/core/html/forms/HiddenInputType.cpp ('k') | Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698