Source/core/html/HTMLMediaElement.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 2b2ba98431ba0b7a231a415e588703ba16fa37c7..b981ae3bd0aa6359666bf9004abe1292cc2265cc 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -580,7 +580,7 @@ PassRefPtr<MediaError> HTMLMediaElement::error() const

return m_error;

}

-void HTMLMediaElement::setSrc(const String& url)

+void HTMLMediaElement::setSrc(const AtomicString& url)

{

setAttribute(srcAttr, url);

}

@@ -2885,7 +2885,7 @@ KURL HTMLMediaElement::selectNextSourceChild(ContentType* contentType, String* k

RefPtr<MediaQuerySet> media = MediaQuerySet::create(source->media());

#if !LOG_DISABLED

if (shouldLog)

- WTF_LOG(Media, "HTMLMediaElement::selectNextSourceChild - 'media' is %s", source->media().utf8().data());

+ WTF_LOG(Media, "HTMLMediaElement::selectNextSourceChild - 'media' is %s", source->media().string().utf8().data());

#endif

if (!screenEval.eval(media.get())) {

UseCounter::count(document(), UseCounter::SourceElementNonMatchingMedia);

« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/html/HTMLMetaElement.h » ('j') | no next file with comments »