Source/core/html/forms/BaseCheckableInputType.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseCheckableInputType.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/BaseCheckableInputType.cpp

diff --git a/Source/core/html/forms/BaseCheckableInputType.cpp b/Source/core/html/forms/BaseCheckableInputType.cpp

index 0b1e73943d3aea80b3bc5a99792b4ac899798d2e..7ffe40b29da09b5859feb4eb739f8ef965be8d86 100644

--- a/Source/core/html/forms/BaseCheckableInputType.cpp

+++ b/Source/core/html/forms/BaseCheckableInputType.cpp

@@ -103,7 +103,7 @@ bool BaseCheckableInputType::storesValueSeparateFromAttribute()

void BaseCheckableInputType::setValue(const String& sanitizedValue, bool, TextFieldEventBehavior)

{

- element().setAttribute(valueAttr, sanitizedValue);

+ element().setAttribute(valueAttr, AtomicString(sanitizedValue));

}

bool BaseCheckableInputType::isCheckable()

« no previous file with comments | « Source/core/html/forms/BaseButtonInputType.cpp ('k') | Source/core/html/forms/HiddenInputType.cpp » ('j') | no next file with comments »