Source/core/html/HTMLSelectElement.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index f27d41b97bae466941982ed9f3d627ea69b289a1..a1490387b4ce5181cf4900006dc551422916f136 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -390,7 +390,7 @@ void HTMLSelectElement::setMultiple(bool multiple)

{

bool oldMultiple = this->multiple();

int oldSelectedIndex = selectedIndex();

- setAttribute(multipleAttr, multiple ? "" : 0);

+ setAttribute(multipleAttr, multiple ? emptyAtom : nullAtom);

// Restore selectedIndex after changing the multiple flag to preserve

// selection as single-line and multi-line has different defaults.

« no previous file with comments | « Source/core/html/HTMLPlugInElement.cpp ('k') | Source/core/html/HTMLSourceElement.h » ('j') | no next file with comments »