Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.h
diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h
index 02198345c4da7bec77eea1b82be836ebf6bd1b3d..04452ab27ba4ad40429ded7206c20399afad8687 100644
--- a/Source/core/html/HTMLInputElement.h
+++ b/Source/core/html/HTMLInputElement.h
@@ -134,7 +134,7 @@ public:
int size() const;
bool sizeShouldIncludeDecoration(int& preferredSize) const;
- void setType(const String&);
+ void setType(const AtomicString&);
String value() const;
void setValue(const String&, ExceptionState&, TextFieldEventBehavior = DispatchNoEvent);
@@ -190,13 +190,13 @@ public:
int maxResults() const { return m_maxResults; }
- String defaultValue() const;
- void setDefaultValue(const String&);
+ const AtomicString& defaultValue() const;
+ void setDefaultValue(const AtomicString&);
Vector<String> acceptMIMETypes();
Vector<String> acceptFileExtensions();
- String accept() const;
- String alt() const;
+ const AtomicString& accept() const;
+ const AtomicString& alt() const;
void setSize(unsigned);
void setSize(unsigned, ExceptionState&);
« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698