Source/core/html/HTMLDetailsElement.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLDetailsElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLDetailsElement.cpp

diff --git a/Source/core/html/HTMLDetailsElement.cpp b/Source/core/html/HTMLDetailsElement.cpp

index f3220bc39e4d721fb10da4f53968e2b95d8bb20b..28c6bbeae6cfad13d228f8d8727feab220362b74 100644

--- a/Source/core/html/HTMLDetailsElement.cpp

+++ b/Source/core/html/HTMLDetailsElement.cpp

@@ -55,7 +55,7 @@ RenderObject* HTMLDetailsElement::createRenderer(RenderStyle*)

void HTMLDetailsElement::didAddUserAgentShadowRoot(ShadowRoot& root)

{

- DEFINE_STATIC_LOCAL(AtomicString, summarySelector, ("summary:first-of-type", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, summarySelector, ("summary:first-of-type", AtomicString::ConstructFromLiteral));

RefPtr<HTMLSummaryElement> defaultSummary = HTMLSummaryElement::create(document());

defaultSummary->appendChild(Text::create(document(), locale().queryString(blink::WebLocalizedString::DetailsLabel)));

« no previous file with comments | « Source/core/html/HTMLButtonElement.cpp ('k') | Source/core/html/HTMLDocument.h » ('j') | no next file with comments »