Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: Source/core/html/HTMLOptionElement.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2010 Google Inc. All rights reserved. 6 * Copyright (C) 2010 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 18 matching lines...) Expand all
29 29
30 namespace WebCore { 30 namespace WebCore {
31 31
32 class ExceptionState; 32 class ExceptionState;
33 class HTMLDataListElement; 33 class HTMLDataListElement;
34 class HTMLSelectElement; 34 class HTMLSelectElement;
35 35
36 class HTMLOptionElement FINAL : public HTMLElement { 36 class HTMLOptionElement FINAL : public HTMLElement {
37 public: 37 public:
38 static PassRefPtr<HTMLOptionElement> create(Document&); 38 static PassRefPtr<HTMLOptionElement> create(Document&);
39 static PassRefPtr<HTMLOptionElement> createForJSConstructor(Document&, const String& data, const String& value, 39 static PassRefPtr<HTMLOptionElement> createForJSConstructor(Document&, const String& data, const AtomicString& value,
40 bool defaultSelected, bool selected, ExceptionState&); 40 bool defaultSelected, bool selected, ExceptionState&);
41 41
42 virtual String text() const; 42 virtual String text() const;
43 void setText(const String&, ExceptionState&); 43 void setText(const String&, ExceptionState&);
44 44
45 int index() const; 45 int index() const;
46 46
47 String value() const; 47 String value() const;
48 void setValue(const String&); 48 void setValue(const AtomicString&);
49 49
50 bool selected(); 50 bool selected();
51 void setSelected(bool); 51 void setSelected(bool);
52 52
53 HTMLDataListElement* ownerDataListElement() const; 53 HTMLDataListElement* ownerDataListElement() const;
54 HTMLSelectElement* ownerSelectElement() const; 54 HTMLSelectElement* ownerSelectElement() const;
55 55
56 String label() const; 56 String label() const;
57 void setLabel(const String&); 57 void setLabel(const AtomicString&);
58 58
59 bool ownElementDisabled() const { return m_disabled; } 59 bool ownElementDisabled() const { return m_disabled; }
60 60
61 virtual bool isDisabledFormControl() const OVERRIDE; 61 virtual bool isDisabledFormControl() const OVERRIDE;
62 62
63 String textIndentedToRespectGroupLabel() const; 63 String textIndentedToRespectGroupLabel() const;
64 64
65 void setSelectedState(bool); 65 void setSelectedState(bool);
66 66
67 private: 67 private:
(...skipping 23 matching lines...) Expand all
91 bool m_disabled; 91 bool m_disabled;
92 bool m_isSelected; 92 bool m_isSelected;
93 RefPtr<RenderStyle> m_style; 93 RefPtr<RenderStyle> m_style;
94 }; 94 };
95 95
96 DEFINE_NODE_TYPE_CASTS(HTMLOptionElement, hasTagName(HTMLNames::optionTag)); 96 DEFINE_NODE_TYPE_CASTS(HTMLOptionElement, hasTagName(HTMLNames::optionTag));
97 97
98 } // namespace WebCore 98 } // namespace WebCore
99 99
100 #endif 100 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698