Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: Source/core/html/forms/BaseButtonInputType.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/PluginDocument.cpp ('k') | Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 return new RenderButton(&element()); 69 return new RenderButton(&element());
70 } 70 }
71 71
72 bool BaseButtonInputType::storesValueSeparateFromAttribute() 72 bool BaseButtonInputType::storesValueSeparateFromAttribute()
73 { 73 {
74 return false; 74 return false;
75 } 75 }
76 76
77 void BaseButtonInputType::setValue(const String& sanitizedValue, bool, TextField EventBehavior) 77 void BaseButtonInputType::setValue(const String& sanitizedValue, bool, TextField EventBehavior)
78 { 78 {
79 element().setAttribute(valueAttr, sanitizedValue); 79 element().setAttribute(valueAttr, AtomicString(sanitizedValue));
80 } 80 }
81 81
82 } // namespace WebCore 82 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/PluginDocument.cpp ('k') | Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698