Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: Source/core/editing/markup.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2011 Igalia S.L. 4 * Copyright (C) 2011 Igalia S.L.
5 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 5 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 { 76 {
77 } 77 }
78 78
79 AttributeChange(PassRefPtr<Element> element, const QualifiedName& name, cons t String& value) 79 AttributeChange(PassRefPtr<Element> element, const QualifiedName& name, cons t String& value)
80 : m_element(element), m_name(name), m_value(value) 80 : m_element(element), m_name(name), m_value(value)
81 { 81 {
82 } 82 }
83 83
84 void apply() 84 void apply()
85 { 85 {
86 m_element->setAttribute(m_name, m_value); 86 m_element->setAttribute(m_name, AtomicString(m_value));
87 } 87 }
88 88
89 private: 89 private:
90 RefPtr<Element> m_element; 90 RefPtr<Element> m_element;
91 QualifiedName m_name; 91 QualifiedName m_name;
92 String m_value; 92 String m_value;
93 }; 93 };
94 94
95 static void completeURLs(DocumentFragment& fragment, const String& baseURL) 95 static void completeURLs(DocumentFragment& fragment, const String& baseURL)
96 { 96 {
(...skipping 985 matching lines...) Expand 10 before | Expand all | Expand 10 after
1082 return; 1082 return;
1083 1083
1084 RefPtr<Text> textNode = toText(node.get()); 1084 RefPtr<Text> textNode = toText(node.get());
1085 RefPtr<Text> textNext = toText(next); 1085 RefPtr<Text> textNext = toText(next);
1086 textNode->appendData(textNext->data()); 1086 textNode->appendData(textNext->data());
1087 if (textNext->parentNode()) // Might have been removed by mutation event. 1087 if (textNext->parentNode()) // Might have been removed by mutation event.
1088 textNext->remove(exceptionState); 1088 textNext->remove(exceptionState);
1089 } 1089 }
1090 1090
1091 } 1091 }
OLDNEW
« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698