Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index f9e76952745befb17e5a477cec7b7448f6067b47..a71bd81002c6cce67eddb8f981769d14c3666833 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -56,10 +56,10 @@ public:
Node* item(unsigned index);
String enctype() const { return m_attributes.encodingType(); }
- void setEnctype(const String&);
+ void setEnctype(const AtomicString&);
String encoding() const { return m_attributes.encodingType(); }
- void setEncoding(const String& value) { setEnctype(value); }
+ void setEncoding(const AtomicString& value) { setEnctype(value); }
bool shouldAutocomplete() const;
@@ -84,14 +84,11 @@ public:
bool noValidate() const;
- String acceptCharset() const { return m_attributes.acceptCharset(); }
- void setAcceptCharset(const String&);
-
- String action() const;
- void setAction(const String&);
+ const AtomicString& action() const;
+ void setAction(const AtomicString&);
String method() const;
- void setMethod(const String&);
+ void setMethod(const AtomicString&);
virtual String target() const;
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698