Source/core/html/PluginDocument.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/PluginDocument.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/PluginDocument.cpp

diff --git a/Source/core/html/PluginDocument.cpp b/Source/core/html/PluginDocument.cpp

index b132b9fd4f98c89f6a826ebf8bfa0892ae265623..366ee643ba3d0dde4b457a15206b0499432a0978 100644

--- a/Source/core/html/PluginDocument.cpp

+++ b/Source/core/html/PluginDocument.cpp

@@ -99,7 +99,7 @@ void PluginDocumentParser::createDocumentStructure()

m_embedElement->setAttribute(widthAttr, "100%");

m_embedElement->setAttribute(heightAttr, "100%");

m_embedElement->setAttribute(nameAttr, "plugin");

- m_embedElement->setAttribute(srcAttr, document()->url().string());

+ m_embedElement->setAttribute(srcAttr, AtomicString(document()->url().string()));

m_embedElement->setAttribute(typeAttr, document()->loader()->mimeType());

body->appendChild(m_embedElement);

« no previous file with comments | « Source/core/html/LinkResource.h ('k') | Source/core/html/forms/BaseButtonInputType.cpp » ('j') | no next file with comments »