Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: Source/core/inspector/DOMEditor.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TextTrack.h ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/DOMEditor.cpp
diff --git a/Source/core/inspector/DOMEditor.cpp b/Source/core/inspector/DOMEditor.cpp
index 2573e69ee46e9947753614d64fa33a07daae367f..cd3a1f5981d4d2f0fee807eee466c83bfbdb9cb9 100644
--- a/Source/core/inspector/DOMEditor.cpp
+++ b/Source/core/inspector/DOMEditor.cpp
@@ -130,7 +130,7 @@ private:
class DOMEditor::RemoveAttributeAction : public InspectorHistory::Action {
WTF_MAKE_NONCOPYABLE(RemoveAttributeAction);
public:
- RemoveAttributeAction(Element* element, const String& name)
+ RemoveAttributeAction(Element* element, const AtomicString& name)
: InspectorHistory::Action("RemoveAttribute")
, m_element(element)
, m_name(name)
@@ -157,14 +157,14 @@ public:
private:
RefPtr<Element> m_element;
- String m_name;
- String m_value;
+ AtomicString m_name;
+ AtomicString m_value;
};
class DOMEditor::SetAttributeAction : public InspectorHistory::Action {
WTF_MAKE_NONCOPYABLE(SetAttributeAction);
public:
- SetAttributeAction(Element* element, const String& name, const String& value)
+ SetAttributeAction(Element* element, const AtomicString& name, const AtomicString& value)
: InspectorHistory::Action("SetAttribute")
, m_element(element)
, m_name(name)
@@ -198,10 +198,10 @@ public:
private:
RefPtr<Element> m_element;
- String m_name;
- String m_value;
+ AtomicString m_name;
+ AtomicString m_value;
bool m_hadAttribute;
- String m_oldValue;
+ AtomicString m_oldValue;
};
class DOMEditor::SetOuterHTMLAction : public InspectorHistory::Action {
« no previous file with comments | « Source/core/html/track/TextTrack.h ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698