Source/core/inspector/InspectorPageAgent.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorPageAgent.cpp

diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp

index d81649a700a663afdac8c39d5614e58fe1c8a342..686c6155bffaf8b23b57ae641b30b4c457dc19b4 100644

--- a/Source/core/inspector/InspectorPageAgent.cpp

+++ b/Source/core/inspector/InspectorPageAgent.cpp

@@ -1032,7 +1032,7 @@ PassRefPtr<TypeBuilder::Page::Frame> InspectorPageAgent::buildObjectForFrame(Fra

if (frame->tree().parent())

frameObject->setParentId(frameId(frame->tree().parent()));

if (frame->ownerElement()) {

- String name = frame->ownerElement()->getNameAttribute();

+ AtomicString name = frame->ownerElement()->getNameAttribute();

if (name.isEmpty())

name = frame->ownerElement()->getAttribute(HTMLNames::idAttr);

frameObject->setName(name);

« no previous file with comments | « Source/core/inspector/DOMEditor.cpp ('k') | Source/core/inspector/InspectorStyleSheet.cpp » ('j') | no next file with comments »