Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/core/html/LinkResource.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLTrackElement.cpp ('k') | Source/core/html/PluginDocument.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 protected: 61 protected:
62 HTMLLinkElement* m_owner; 62 HTMLLinkElement* m_owner;
63 }; 63 };
64 64
65 class LinkRequestBuilder { 65 class LinkRequestBuilder {
66 public: 66 public:
67 explicit LinkRequestBuilder(HTMLLinkElement* owner); 67 explicit LinkRequestBuilder(HTMLLinkElement* owner);
68 68
69 bool isValid() const { return !m_url.isEmpty() && m_url.isValid(); } 69 bool isValid() const { return !m_url.isEmpty() && m_url.isValid(); }
70 const KURL& url() const { return m_url; } 70 const KURL& url() const { return m_url; }
71 const String& charset() const { return m_charset; } 71 const AtomicString& charset() const { return m_charset; }
72 FetchRequest build(bool blocking) const; 72 FetchRequest build(bool blocking) const;
73 73
74 private: 74 private:
75 HTMLLinkElement* m_owner; 75 HTMLLinkElement* m_owner;
76 KURL m_url; 76 KURL m_url;
77 String m_charset; 77 AtomicString m_charset;
78 }; 78 };
79 79
80 } // namespace WebCore 80 } // namespace WebCore
81 81
82 #endif // LinkResource_h 82 #endif // LinkResource_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTrackElement.cpp ('k') | Source/core/html/PluginDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698