Source/core/html/HTMLButtonElement.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLButtonElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLButtonElement.cpp

diff --git a/Source/core/html/HTMLButtonElement.cpp b/Source/core/html/HTMLButtonElement.cpp

index d70626f755fb1c3aeb840c789a9e76cb2ccdb039..4b3c235fdab8ef013eca50e1f1df847e2349b531 100644

--- a/Source/core/html/HTMLButtonElement.cpp

+++ b/Source/core/html/HTMLButtonElement.cpp

@@ -194,7 +194,7 @@ bool HTMLButtonElement::isURLAttribute(const Attribute& attribute) const

return attribute.name() == formactionAttr || HTMLFormControlElement::isURLAttribute(attribute);

}

-String HTMLButtonElement::value() const

+const AtomicString& HTMLButtonElement::value() const

{

return getAttribute(valueAttr);

}

« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLDetailsElement.cpp » ('j') | no next file with comments »