Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: Source/core/html/HTMLSourceElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSourceElement.h ('k') | Source/core/html/HTMLTableCellElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSourceElement.cpp
diff --git a/Source/core/html/HTMLSourceElement.cpp b/Source/core/html/HTMLSourceElement.cpp
index 9d213d471a34c29978edeb06b22a6653a1351cc2..75daceb07a42bbfeda2bebab011f17558e2a7da9 100644
--- a/Source/core/html/HTMLSourceElement.cpp
+++ b/Source/core/html/HTMLSourceElement.cpp
@@ -72,25 +72,25 @@ void HTMLSourceElement::removedFrom(ContainerNode* removalRoot)
void HTMLSourceElement::setSrc(const String& url)
{
- setAttribute(srcAttr, url);
+ setAttribute(srcAttr, AtomicString(url));
}
-String HTMLSourceElement::media() const
+const AtomicString& HTMLSourceElement::media() const
{
return getAttribute(mediaAttr);
}
-void HTMLSourceElement::setMedia(const String& media)
+void HTMLSourceElement::setMedia(const AtomicString& media)
{
setAttribute(mediaAttr, media);
}
-String HTMLSourceElement::type() const
+const AtomicString& HTMLSourceElement::type() const
{
return getAttribute(typeAttr);
}
-void HTMLSourceElement::setType(const String& type)
+void HTMLSourceElement::setType(const AtomicString& type)
{
setAttribute(typeAttr, type);
}
« no previous file with comments | « Source/core/html/HTMLSourceElement.h ('k') | Source/core/html/HTMLTableCellElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698