|
GURL::Replacements methods accept a StringPiece instead of std::string&.
Previously, it was unsafe to pass a char* because it would be implicitly
converted to a string with a very short lifetime. Now, you can safely
pass a char* as long as the memory pointed to by the char* outlives the
Replacements (which is always true for string literals).
All existing usage of Replacements should continue to work as usual.
Updated every call to Replacements Set*Str methods that that could be
simplified by the new StringPiece API (for example, passing string
literals directly, instead of copying them into a string object).
Internally, renamed StdStringReplacements to StringPieceReplacements.
BUG= 454274
Committed: https://crrev.com/77752c3e55c59747a62a362799ac6de5ff56fd45
Cr-Commit-Position: refs/heads/master@{#314771}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+140 lines, -224 lines) |
Patch |
|
M |
chrome/browser/android/logo_service.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/apps/app_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/apps/guest_view/web_view_browsertest.cc
|
View
|
1
2
3
|
4 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/captive_portal/captive_portal_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/app_mode/fake_cws.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/login/test/oobe_base_test.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
|
View
|
1
2
3
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/app_process_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/chrome_app_api_browsertest.cc
|
View
|
1
2
|
4 chunks |
+26 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/content_script_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_dom_clipboard_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_nacl_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_resource_request_policy_apitest.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/isolated_app_browsertest.cc
|
View
|
|
6 chunks |
+6 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/process_management_browsertest.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/process_manager_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/window_open_apitest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/cookie_policy_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/proxy_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/websocket_browsertest.cc
|
View
|
|
3 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/prerender/prerender_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/search/search.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ssl/ssl_browser_tests.cc
|
View
|
|
4 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc
|
View
|
|
2 chunks |
+8 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/task_manager/task_manager_browsertest.cc
|
View
|
|
3 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/app_list/start_page_service.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/login/login_prompt_browsertest.cc
|
View
|
1
2
|
4 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
components/google/core/browser/google_util.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/omnibox/autocomplete_match.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/search_engines/search_terms_data.cc
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/accessibility/site_per_process_accessibility_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/browser/cross_site_transfer_browsertest.cc
|
View
|
|
8 chunks |
+10 lines, -22 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_process_host_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/shared_worker/worker_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/opened_by_dom_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl_browsertest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/public/test/browser_test_utils.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/test/browser_test_utils_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
extensions/browser/guest_view/web_view/web_view_apitest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
net/http/http_stream_factory_impl.cc
|
View
|
1
2
3
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/url_request/url_request_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/websockets/websocket_end_to_end_test.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
url/gurl.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
url/url_canon_stdstring.h
|
View
|
|
2 chunks |
+13 lines, -12 lines |
0 comments
|
Download
|
Total messages: 11 (4 generated)
|