net/url_request/url_request_unittest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_unittest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_unittest.cc

diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc

index c3bc1668ec97f1eada6ef0a59ebc98846d48405c..5937464aae17550f829f7274a8b647b39d62dc07 100644

--- a/net/url_request/url_request_unittest.cc

+++ b/net/url_request/url_request_unittest.cc

@@ -5989,10 +5989,8 @@ TEST_F(URLRequestTestHTTP, BasicAuthWithCookies) {

TestDelegate d;

GURL::Replacements replacements;

- std::string username("user2");

- std::string password("secret");

- replacements.SetUsernameStr(username);

- replacements.SetPasswordStr(password);

+ replacements.SetUsernameStr("user2");

+ replacements.SetPasswordStr("secret");

GURL url_with_identity = url_requiring_auth.ReplaceComponents(replacements);

scoped_ptr<URLRequest> r(context.CreateRequest(

« no previous file with comments | « net/http/http_stream_factory_impl.cc ('k') | net/websockets/websocket_end_to_end_test.cc » ('j') | no next file with comments »