chrome/browser/extensions/extension_resource_request_policy_apitest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_resource_request_policy_apitest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_nacl_browsertest.cc ('k') | chrome/browser/extensions/isolated_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_resource_request_policy_apitest.cc

diff --git a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

index 7553bda5b10cd42bf89097bdd24ed5456f9ff5d4..2f2fbf8313265ef5d185db18b38a656597369d00 100644

--- a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

+++ b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc

@@ -48,13 +48,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) {

"files/extensions/api_test/extension_resource_request_policy/"

"index.html"));

- std::string host_a("a.com");

GURL::Replacements make_host_a_com;

- make_host_a_com.SetHostStr(host_a);

+ make_host_a_com.SetHostStr("a.com");

- std::string host_b("b.com");

GURL::Replacements make_host_b_com;

- make_host_b_com.SetHostStr(host_b);

+ make_host_b_com.SetHostStr("b.com");

// A web host that has permission.

ui_test_utils::NavigateToURL(

« no previous file with comments | « chrome/browser/extensions/extension_nacl_browsertest.cc ('k') | chrome/browser/extensions/isolated_app_browsertest.cc » ('j') | no next file with comments »