chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

diff --git a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

index c890d6adf0883cc09662d1348b59af92edc4be29..1ff40fe0157f5753d5bfb248bd9513be8c9f519e 100644

--- a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

+++ b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

@@ -368,8 +368,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,

// Whitelist iframe URL instead.

GURL::Replacements replace_host;

- std::string host_str("www.a.com"); // Must stay in scope with replace_host

- replace_host.SetHostStr(host_str);

+ replace_host.SetHostStr("www.a.com");

GURL frame_url(embedded_test_server()

->GetURL("/popup_blocker/popup-frames-iframe.html")

.ReplaceComponents(replace_host));

« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/login/login_prompt_browsertest.cc » ('j') | no next file with comments »