Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2256)

Unified Diff: chrome/browser/net/proxy_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/cookie_policy_browsertest.cc ('k') | chrome/browser/net/websocket_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/proxy_browsertest.cc
diff --git a/chrome/browser/net/proxy_browsertest.cc b/chrome/browser/net/proxy_browsertest.cc
index ca230acb9d0749559be05f546eb7ff211b8d8a52..d705a09521d02f77178932bfa8e7622be2042366 100644
--- a/chrome/browser/net/proxy_browsertest.cc
+++ b/chrome/browser/net/proxy_browsertest.cc
@@ -129,9 +129,8 @@ IN_PROC_BROWSER_TEST_F(ProxyBrowserTest, MAYBE_BasicAuthWSConnect) {
// Visit a page that tries to establish WebSocket connection. The title
// of the page will be 'PASS' on success.
- std::string scheme("http");
GURL::Replacements replacements;
- replacements.SetSchemeStr(scheme);
+ replacements.SetSchemeStr("http");
ui_test_utils::NavigateToURL(browser(),
ws_server.GetURL("proxied_request_check.html")
.ReplaceComponents(replacements));
« no previous file with comments | « chrome/browser/net/cookie_policy_browsertest.cc ('k') | chrome/browser/net/websocket_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698