Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: chrome/browser/net/cookie_policy_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/browser/net/proxy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/cookie_policy_browsertest.cc
diff --git a/chrome/browser/net/cookie_policy_browsertest.cc b/chrome/browser/net/cookie_policy_browsertest.cc
index f04ec04c0633682553403b28ee448f16edb78916..e79300a547099752794efb5434028f75c7c7ec52 100644
--- a/chrome/browser/net/cookie_policy_browsertest.cc
+++ b/chrome/browser/net/cookie_policy_browsertest.cc
@@ -63,8 +63,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest,
// changed when we follow a redirect.
ASSERT_EQ("127.0.0.1", redirected_url.host());
GURL::Replacements replacements;
- std::string new_host("www.example.com");
- replacements.SetHostStr(new_host);
+ replacements.SetHostStr("www.example.com");
redirected_url = redirected_url.ReplaceComponents(replacements);
std::string cookie =
« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/browser/net/proxy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698