content/browser/web_contents/opened_by_dom_browsertest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/opened_by_dom_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/worker_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/opened_by_dom_browsertest.cc

diff --git a/content/browser/web_contents/opened_by_dom_browsertest.cc b/content/browser/web_contents/opened_by_dom_browsertest.cc

index 9a20a94c286a126dc7963a9fd54382b13efde7ce..dab6eb8d3180845a63c920b7e0003dd9e724d31d 100644

--- a/content/browser/web_contents/opened_by_dom_browsertest.cc

+++ b/content/browser/web_contents/opened_by_dom_browsertest.cc

@@ -123,8 +123,7 @@ IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, DISABLED_CrossProcessPopup) {

GURL url2 = test_server()->GetURL("files/site_isolation/blank.html?2");

GURL::Replacements replace_host;

- std::string foo_com("foo.com");

- replace_host.SetHostStr(foo_com);

+ replace_host.SetHostStr("foo.com");

url2 = url2.ReplaceComponents(replace_host);

GURL url3 = test_server()->GetURL("files/site_isolation/blank.html?3");