chrome/browser/extensions/content_script_apitest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/content_script_apitest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_app_api_browsertest.cc ('k') | chrome/browser/extensions/extension_dom_clipboard_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/content_script_apitest.cc

diff --git a/chrome/browser/extensions/content_script_apitest.cc b/chrome/browser/extensions/content_script_apitest.cc

index a8d8322d5b20ffda5ce8e3c85cce150f34069dfd..ed60dcb7d1c2c41ac36ceccb64f4ccf2a73dc8a5 100644

--- a/chrome/browser/extensions/content_script_apitest.cc

+++ b/chrome/browser/extensions/content_script_apitest.cc

@@ -338,8 +338,7 @@ IN_PROC_BROWSER_TEST_F(ContentScriptCssInjectionTest,

// We disallow all injection on the webstore.

GURL::Replacements replacements;

- std::string host(kWebstoreDomain);

- replacements.SetHostStr(host);

+ replacements.SetHostStr(kWebstoreDomain);

url = embedded_test_server()->GetURL("/extensions/test_file_with_body.html")

.ReplaceComponents(replacements);

EXPECT_TRUE(CheckStyleInjection(browser(), url, false));