chrome/browser/extensions/api/streams_private/streams_private_apitest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

index 2faf9f225ad79a55725db393de70bca6be27a390..01b690ef1c1e131a172a5d4bfb15adf1cf4ad12f 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc

@@ -316,10 +316,10 @@ IN_PROC_BROWSER_TEST_F(StreamsPrivateApiTest, NavigateCrossSite) {

ResultCatcher catcher;

// Navigate to a URL on a different hostname.

- std::string initial_host = "www.example.com";

- host_resolver()->AddRule(initial_host, "127.0.0.1");

+ static const char kInitialHost[] = "www.example.com";

+ host_resolver()->AddRule(kInitialHost, "127.0.0.1");

GURL::Replacements replacements;

- replacements.SetHostStr(initial_host);

+ replacements.SetHostStr(kInitialHost);

GURL initial_url =

test_server_->GetURL("/index.html").ReplaceComponents(replacements);

ui_test_utils::NavigateToURL(browser(), initial_url);