url/gurl.h - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.h

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url/gurl.h

diff --git a/url/gurl.h b/url/gurl.h

index ef1e5290bcc924787095e234d05177eaa11caac4..566fc5e18317f899738a705c310c81b03ec13b7a 100644

--- a/url/gurl.h

+++ b/url/gurl.h

@@ -18,8 +18,8 @@

class URL_EXPORT GURL {

public:

- typedef url::StdStringReplacements<std::string> Replacements;

- typedef url::StdStringReplacements<base::string16> ReplacementsW;

+ typedef url::StringPieceReplacements<std::string> Replacements;

+ typedef url::StringPieceReplacements<base::string16> ReplacementsW;

// Creates an empty, invalid URL.

GURL();

« no previous file with comments | « net/websockets/websocket_end_to_end_test.cc ('k') | url/url_canon_stdstring.h » ('j') | no next file with comments »