Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4520)

Unified Diff: chrome/browser/android/logo_service.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/logo_service.cc
diff --git a/chrome/browser/android/logo_service.cc b/chrome/browser/android/logo_service.cc
index ac0351c9c859714c899ee762edd28aa9ac5794c1..ddcb626361050d372542a332ab237ab94479e4ed 100644
--- a/chrome/browser/android/logo_service.cc
+++ b/chrome/browser/android/logo_service.cc
@@ -31,11 +31,8 @@ const int kDecodeLogoTimeoutSeconds = 30;
GURL GetGoogleDoodleURL(Profile* profile) {
GURL google_base_url(UIThreadSearchTermsData(profile).GoogleBaseURLValue());
const char kGoogleDoodleURLPath[] = "async/newtab_mobile";
- // The string passed to SetPathStr() must stay alive until after
- // ReplaceComponents(), so declare it on the stack here instead of inline.
- std::string path(kGoogleDoodleURLPath);
GURL::Replacements replacements;
- replacements.SetPathStr(path);
+ replacements.SetPathStr(kGoogleDoodleURLPath);
return google_base_url.ReplaceComponents(replacements);
}
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698