chrome/browser/task_manager/task_manager_browsertest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest.cc

diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc

index 3a79f59113bba11160597f8d3d1c90599b2f35b3..2cd1796a4e096271e3f6b03c9d813e0b1f15656e 100644

--- a/chrome/browser/task_manager/task_manager_browsertest.cc

+++ b/chrome/browser/task_manager/task_manager_browsertest.cc

@@ -606,8 +606,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeHostedAppTabChanges) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

GURL::Replacements replace_host;

- std::string host_str("localhost"); // must stay in scope with replace_host

- replace_host.SetHostStr(host_str);

+ replace_host.SetHostStr("localhost");

GURL base_url = embedded_test_server()->GetURL(

"/extensions/api_test/app_process/");

base_url = base_url.ReplaceComponents(replace_host);

@@ -671,8 +670,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeHostedAppTabAfterReload) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

GURL::Replacements replace_host;

- std::string host_str("localhost"); // must stay in scope with replace_host

- replace_host.SetHostStr(host_str);

+ replace_host.SetHostStr("localhost");

GURL base_url =

embedded_test_server()->GetURL("/extensions/api_test/app_process/");

base_url = base_url.ReplaceComponents(replace_host);

@@ -707,8 +705,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeHostedAppTabBeforeReload) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

GURL::Replacements replace_host;

- std::string host_str("localhost"); // must stay in scope with replace_host

- replace_host.SetHostStr(host_str);

+ replace_host.SetHostStr("localhost");

GURL base_url =

embedded_test_server()->GetURL("/extensions/api_test/app_process/");

base_url = base_url.ReplaceComponents(replace_host);