GURL::Replacements methods accept a StringPiece instead of std::string&.

chrome/browser/apps/guest_view/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/chrome_content_browser_client.h"
 #include "chrome/browser/prerender/prerender_link_manager.h"
@@ skipping 337 matching lines @@
   void NavigateAndOpenAppForIsolation(
       GURL navigate_to_url,
       content::WebContents** default_tag_contents1,
       content::WebContents** default_tag_contents2,
       content::WebContents** named_partition_contents1,
       content::WebContents** named_partition_contents2,
       content::WebContents** persistent_partition_contents1,
       content::WebContents** persistent_partition_contents2,
       content::WebContents** persistent_partition_contents3) {
     GURL::Replacements replace_host;
-    std::string host_str("localhost");  // Must stay in scope with replace_host.
-    replace_host.SetHostStr(host_str);
+    replace_host.SetHostStr("localhost");
 
     navigate_to_url = navigate_to_url.ReplaceComponents(replace_host);
 
     GURL tag_url1 = embedded_test_server()->GetURL(
         "/extensions/platform_apps/web_view/isolation/cookie.html");
     tag_url1 = tag_url1.ReplaceComponents(replace_host);
     GURL tag_url2 = embedded_test_server()->GetURL(
         "/extensions/platform_apps/web_view/isolation/cookie2.html");
     tag_url2 = tag_url2.ReplaceComponents(replace_host);
     GURL tag_url3 = embedded_test_server()->GetURL(
@@ skipping 247 matching lines @@
             base::StringPrintf("runTest('%s')", test_name.c_str()))) {
       LOG(ERROR) << "UNABLE TO START TEST.";
       return;
     }
     ASSERT_TRUE(done_listener.WaitUntilSatisfied());
   }
 
   content::WebContents* LoadGuest(const std::string& guest_path,
                                   const std::string& app_path) {
     GURL::Replacements replace_host;
-    std::string host_str("localhost");  // Must stay in scope with replace_host.
-    replace_host.SetHostStr(host_str);
+    replace_host.SetHostStr("localhost");
 
     GURL guest_url = embedded_test_server()->GetURL(guest_path);
     guest_url = guest_url.ReplaceComponents(replace_host);
 
     ui_test_utils::UrlLoadObserver guest_observer(
         guest_url, content::NotificationService::AllSources());
 
     LoadAndLaunchPlatformApp(app_path.c_str(), "guest-loaded");
 
     guest_observer.Wait();
@@ skipping 559 matching lines @@
 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestRemoveWebviewOnExit) {
   ASSERT_TRUE(StartEmbeddedTestServer());  // For serving guest pages.
 
   // Launch the app and wait until it's ready to load a test.
   LoadAndLaunchPlatformApp("web_view/shim", "Launched");
 
   content::WebContents* embedder_web_contents = GetFirstAppWindowWebContents();
   ASSERT_TRUE(embedder_web_contents);
 
   GURL::Replacements replace_host;
-  std::string host_str("localhost");  // Must stay in scope with replace_host.
-  replace_host.SetHostStr(host_str);
+  replace_host.SetHostStr("localhost");
 
   std::string guest_path(
       "/extensions/platform_apps/web_view/shim/empty_guest.html");
   GURL guest_url = embedded_test_server()->GetURL(guest_path);
   guest_url = guest_url.ReplaceComponents(replace_host);
 
   ui_test_utils::UrlLoadObserver guest_observer(
       guest_url, content::NotificationService::AllSources());
 
   // Run the test and wait until the guest WebContents is available and has
@@ skipping 169 matching lines @@
   const std::string kExpire =
       "var expire = new Date(Date.now() + 24 * 60 * 60 * 1000);";
   std::string cookie_script1(kExpire);
   cookie_script1.append(
       "document.cookie = 'guest1=true; path=/; expires=' + expire + ';';");
   std::string cookie_script2(kExpire);
   cookie_script2.append(
       "document.cookie = 'guest2=true; path=/; expires=' + expire + ';';");
 
   GURL::Replacements replace_host;
-  std::string host_str("localhost");  // Must stay in scope with replace_host.
-  replace_host.SetHostStr(host_str);
+  replace_host.SetHostStr("localhost");
 
   GURL set_cookie_url = embedded_test_server()->GetURL(
       "/extensions/platform_apps/isolation/set_cookie.html");
   set_cookie_url = set_cookie_url.ReplaceComponents(replace_host);
 
   // The first two partitions will be used to set cookies and ensure they are
   // shared. The named partition is used to ensure that cookies are isolated
   // between partitions within the same app.
   content::WebContents* cookie_contents1;
   content::WebContents* cookie_contents2;
@@ skipping 1068 matching lines @@
 // http://crbug.com/403325
 #define MAYBE_WebViewInBackgroundPage \
     DISABLED_WebViewInBackgroundPage
 #else
 #define MAYBE_WebViewInBackgroundPage WebViewInBackgroundPage
 #endif
 IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_WebViewInBackgroundPage) {
   ASSERT_TRUE(RunExtensionTest("platform_apps/web_view/background"))
       << message_;
 }