content/browser/shared_worker/worker_browsertest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/worker_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_browsertest.cc ('k') | content/browser/web_contents/opened_by_dom_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/worker_browsertest.cc

diff --git a/content/browser/shared_worker/worker_browsertest.cc b/content/browser/shared_worker/worker_browsertest.cc

index ce39df5788c24189d49063644097d9e54da44f0b..14100b9d72f2cdc6b099bab02668c11e48abe014 100644

--- a/content/browser/shared_worker/worker_browsertest.cc

+++ b/content/browser/shared_worker/worker_browsertest.cc

@@ -118,9 +118,8 @@ IN_PROC_BROWSER_TEST_F(WorkerTest, WebSocketSharedWorker) {

ASSERT_TRUE(ws_server.Start());

// Generate test URL.

- std::string scheme("http");

GURL::Replacements replacements;

- replacements.SetSchemeStr(scheme);

+ replacements.SetSchemeStr("http");

GURL url = ws_server.GetURL(

"websocket_shared_worker.html").ReplaceComponents(replacements);