Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: content/test/browser_test_utils_browsertest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/browser_test_utils_browsertest.cc
diff --git a/content/test/browser_test_utils_browsertest.cc b/content/test/browser_test_utils_browsertest.cc
index de64115f602a4bcea73f8ede1160cdad7f0c3d54..15f65aee3c4752f5af5ec61b6820a5f7fbe7d8ff 100644
--- a/content/test/browser_test_utils_browsertest.cc
+++ b/content/test/browser_test_utils_browsertest.cc
@@ -70,9 +70,8 @@ IN_PROC_BROWSER_TEST_F(CrossSiteRedirectorBrowserTest,
// hostname supplied in the URL and rewrite the URL. Build the
// expected URL to ensure navigation was properly redirected.
GURL::Replacements replace_host;
- std::string foo_com("foo.com");
GURL expected_url(embedded_test_server()->GetURL("/title2.html"));
- replace_host.SetHostStr(foo_com);
+ replace_host.SetHostStr("foo.com");
expected_url = expected_url.ReplaceComponents(replace_host);
EXPECT_EQ(expected_url, observer.navigation_url());
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698