extensions/browser/guest_view/web_view/web_view_apitest.cc - Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 889463003: GURL::Replacements methods accept a StringPiece instead of std::string&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (fixed some merge conflicts). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/web_view/web_view_apitest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc

index 2e63b790e4d353eca1e578cd61fc2f70d7e07793..ff9869f88281f69c1c6ac0f40a00ff60f5b59b81 100644

--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc

@@ -636,8 +636,7 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestRemoveWebviewOnExit) {

LaunchApp("web_view/apitest");

GURL::Replacements replace_host;

- std::string host_str("localhost"); // Must stay in scope with replace_host.

- replace_host.SetHostStr(host_str);

+ replace_host.SetHostStr("localhost");

// Run the test and wait until the guest WebContents is available and has

// finished loading.

« no previous file with comments | « content/test/browser_test_utils_browsertest.cc ('k') | net/http/http_stream_factory_impl.cc » ('j') | no next file with comments »