Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 635533005: Revert of Cleanup of shader building system (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@solo_gp
Project:
skia
Visibility:
Public.

Description

Revert of Cleanup of shader building system (patchset #25 id:470001 of https://codereview.chromium.org/611653002/) Reason for revert: Seems to have messed up windows 7 gms Original issue's description: > Cleanup of shader building system > > this is a huge refactor and cleanup of the gl shader building system in > Skia. The entire shader building pipeline is now part of > GrGLProgramCreator, which takes a gp, and some fps, and creates a > program. I added some subclasses of GrGLProgram to handle the > eccentricities of Nvpr/Nvpres. Outside of the builders folder > and GrGLPrograms, this change is basically just a rename > > > solo gp > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fe1233c3f12f81bb675718516bbb32f72af726ec TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/db0d3ca07008ea2c1f24d0fd9ceecf10af6ae63b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2103 lines, -1782 lines) Patch
M gyp/gpu.gypi View 2 chunks +9 lines, -7 lines 0 comments Download
M include/gpu/GrPaint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrProcessorStage.h View 3 chunks +6 lines, -14 lines 0 comments Download
M include/gpu/GrTBackendProcessorFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 6 chunks +29 lines, -138 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 6 chunks +62 lines, -236 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 3 chunks +27 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 4 chunks +34 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
A src/gpu/gl/GrGLProgramEffects.h View 1 chunk +201 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLProgramEffects.cpp View 1 chunk +204 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 4 chunks +2 lines, -6 lines 0 comments Download
A src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.cpp View 1 chunk +107 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 4 chunks +35 lines, -47 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 8 chunks +213 lines, -190 lines 0 comments Download
A src/gpu/gl/builders/GrGLFullProgramBuilder.h View 1 chunk +130 lines, -0 lines 0 comments Download
A src/gpu/gl/builders/GrGLFullProgramBuilder.cpp View 1 chunk +221 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
D src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.h View 1 chunk +0 lines, -30 lines 0 comments Download
D src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D src/gpu/gl/builders/GrGLNvprProgramBuilder.h View 1 chunk +0 lines, -56 lines 0 comments Download
D src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 3 chunks +281 lines, -285 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 7 chunks +211 lines, -397 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 6 chunks +29 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 3 chunks +26 lines, -17 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 5 chunks +109 lines, -90 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshua.litt
Created Revert of Cleanup of shader building system
6 years, 2 months ago (2014-10-07 19:41:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635533005/1
6 years, 2 months ago (2014-10-07 19:41:52 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 19:42:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as db0d3ca07008ea2c1f24d0fd9ceecf10af6ae63b

Powered by Google App Engine
This is Rietveld 408576698