Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760
Committed: https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec
Cr-Commit-Position: refs/heads/master@{#439409}

[tkent, 2016-12-16 05:52:48]

Description was changed from

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED

to DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
This CL has no behavior changes.

BUG=596760
==========

to

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

to DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
This CL has no behavior changes.

BUG=596760
==========

[tkent, 2016-12-16 05:53:27]

tkent@chromium.org changed reviewers:
+ yutak@chromium.org

[tkent, 2016-12-16 05:53:28]

yutak@, would you review this please?

[tkent, 2016-12-16 06:07:20]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-12-16 06:07:40]

Description was changed from

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

to DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
This CL has no behavior changes.

BUG=596760
==========

to

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
This CL has no behavior changes.

BUG=596760
==========

[commit-bot: I haz the power, 2016-12-16 06:07:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2016-12-16 06:12:39]

LGTM

https://codereview.chromium.org/2585673002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2585673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:19:
#define UNIMPLEMENTED NOTREACHED
Is this used anywhere?

[tkent, 2016-12-16 06:16:55]

https://codereview.chromium.org/2585673002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2585673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:19:
#define UNIMPLEMENTED NOTREACHED
On 2016/12/16 at 06:12:39, Yuta Kitamura wrote:
> Is this used anywhere?

Wow, it's not used in OffscreenCanvasRenderingContext2D.cpp.  I'll remove it.

[tkent, 2016-12-16 06:25:40]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 06:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-12-16 06:27:42]

Description was changed from

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
This CL has no behavior changes.

BUG=596760
==========

to

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760
==========

[commit-bot: I haz the power, 2016-12-16 07:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 07:28:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2016-12-16 07:38:52]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 07:39:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-12-16 07:47:21]

Patchset #2 (id:20001) has been deleted

[tkent, 2016-12-16 09:31:28]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-12-16 09:31:34]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-12-16 09:31:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2585673002/#ps40001
(title: "Remove one of UNIMPLEMENTED macros")

[commit-bot: I haz the power, 2016-12-16 09:32:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 10:48:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2016-12-19 01:40:34]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 01:40:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 04:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 04:21:10]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-12-19 04:21:33]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-12-19 04:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2585673002/#ps60001
(title: "Fix an Asan issue with LinkedHashSetNodeBase::unlink")

[commit-bot: I haz the power, 2016-12-19 04:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 04:28:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482121293480160,
"parent_rev": "69d45d1192c89fda7b09b7309150dded4d4acddf", "commit_rev":
"f52afd93fa99e1f11f5a6dd1a1b12d93a47babf9"}

[commit-bot: I haz the power, 2016-12-19 04:28:42]

Description was changed from

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760
==========

to

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2585673002
==========

[commit-bot: I haz the power, 2016-12-19 04:28:43]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-19 04:32:36]

Description was changed from

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2585673002
==========

to

==========
Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760

Committed: https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec
Cr-Commit-Position: refs/heads/master@{#439409}
==========

[commit-bot: I haz the power, 2016-12-19 04:32:37]

Patchset 3 (id:??) landed as
https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec
Cr-Commit-Position: refs/heads/master@{#439409}