third_party/WebKit/Source/wtf/text/StringOperators.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringOperators.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringOperators.h

diff --git a/third_party/WebKit/Source/wtf/text/StringOperators.h b/third_party/WebKit/Source/wtf/text/StringOperators.h

index d39c45bb104b7449a3af11495ed7dd27ba649586..1ccb63eabef157e25259bd18d704af7c514dffab 100644

--- a/third_party/WebKit/Source/wtf/text/StringOperators.h

+++ b/third_party/WebKit/Source/wtf/text/StringOperators.h

@@ -83,7 +83,7 @@ bool StringAppend<StringType1, StringType2>::is8Bit() const {

template <typename StringType1, typename StringType2>

void StringAppend<StringType1, StringType2>::writeTo(LChar* destination) const {

- ASSERT(is8Bit());

+ DCHECK(is8Bit());

StringTypeAdapter<StringType1> adapter1(m_string1);

StringTypeAdapter<StringType2> adapter2(m_string2);

adapter1.writeTo(destination);