third_party/WebKit/Source/wtf/text/StringConcatenate.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringConcatenate.h

diff --git a/third_party/WebKit/Source/wtf/text/StringConcatenate.h b/third_party/WebKit/Source/wtf/text/StringConcatenate.h

index 7be335600dddd622d006ca1f4ae5c3384b7fc534..326921b65d5d4cf458ec95748b45adc8322ee408 100644

--- a/third_party/WebKit/Source/wtf/text/StringConcatenate.h

+++ b/third_party/WebKit/Source/wtf/text/StringConcatenate.h

@@ -91,7 +91,7 @@ class StringTypeAdapter<UChar> {

bool is8Bit() const { return m_buffer <= 0xff; }

void writeTo(LChar* destination) const {

- ASSERT(is8Bit());

+ DCHECK(is8Bit());

*destination = static_cast<LChar>(m_buffer);

}