third_party/WebKit/Source/wtf/dtoa/double-conversion.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/dtoa/double-conversion.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/dtoa/double-conversion.h

diff --git a/third_party/WebKit/Source/wtf/dtoa/double-conversion.h b/third_party/WebKit/Source/wtf/dtoa/double-conversion.h

index 71a56a0ec0b73645a95442a018973d63999a74ff..17ad7c0df8fd128a0833b5b93a4e7f21098ec574 100644

--- a/third_party/WebKit/Source/wtf/dtoa/double-conversion.h

+++ b/third_party/WebKit/Source/wtf/dtoa/double-conversion.h

@@ -126,7 +126,7 @@ class DoubleToStringConverter {

max_trailing_padding_zeroes_in_precision_mode) {

// When 'trailing zero after the point' is set, then 'trailing point'

// must be set too.

- ASSERT(((flags & EMIT_TRAILING_DECIMAL_POINT) != 0) ||

+ DCHECK(((flags & EMIT_TRAILING_DECIMAL_POINT) != 0) ||

!((flags & EMIT_TRAILING_ZERO_AFTER_POINT) != 0));

}