third_party/WebKit/Source/wtf/ThreadingPrimitives.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/ThreadingPrimitives.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/ThreadingPrimitives.h

diff --git a/third_party/WebKit/Source/wtf/ThreadingPrimitives.h b/third_party/WebKit/Source/wtf/ThreadingPrimitives.h

index 86dd8d006303405a01c178dc2109e30054c6ae99..84b72a6f19ff00a2494db3c3e71cb89308541ac3 100644

--- a/third_party/WebKit/Source/wtf/ThreadingPrimitives.h

+++ b/third_party/WebKit/Source/wtf/ThreadingPrimitives.h

@@ -50,7 +50,7 @@ namespace WTF {

#if OS(POSIX)

struct PlatformMutex {

pthread_mutex_t m_internalMutex;

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

size_t m_recursionCount;

#endif

};

@@ -85,7 +85,7 @@ class WTF_EXPORT MutexBase {

void lock();

void unlock();

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

bool locked() { return m_mutex.m_recursionCount > 0; }

#endif