third_party/WebKit/Source/wtf/LinkedStack.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/LinkedStack.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/LinkedStack.h

diff --git a/third_party/WebKit/Source/wtf/LinkedStack.h b/third_party/WebKit/Source/wtf/LinkedStack.h

index 414d9959325b06cdf62926d1c3c4ad2d76668b74..7d0bb9940d5b5287be2a672bb376db0ac33b47ce 100644

--- a/third_party/WebKit/Source/wtf/LinkedStack.h

+++ b/third_party/WebKit/Source/wtf/LinkedStack.h

@@ -96,7 +96,8 @@ inline const T& LinkedStack<T>::peek() {

template <typename T>

inline void LinkedStack<T>::pop() {

- ASSERT(m_head && m_size);

+ DCHECK(m_head);

+ DCHECK(m_size);

m_head = m_head->m_next.release();

--m_size;

}