third_party/WebKit/Source/wtf/text/TextEncoding.cpp - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncoding.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextEncoding.cpp

diff --git a/third_party/WebKit/Source/wtf/text/TextEncoding.cpp b/third_party/WebKit/Source/wtf/text/TextEncoding.cpp

index 10e62ca03e5f9a0c81aff4a0c198104ee49266ce..e92f80a470348bc014c091834daff11165a31746 100644

--- a/third_party/WebKit/Source/wtf/text/TextEncoding.cpp

+++ b/third_party/WebKit/Source/wtf/text/TextEncoding.cpp

@@ -180,7 +180,7 @@ const TextEncoding& UTF32LittleEndianEncoding() {

const TextEncoding& UTF8Encoding() {

DEFINE_THREAD_SAFE_STATIC_LOCAL(const TextEncoding, globalUTF8Encoding,

new TextEncoding("UTF-8"));

- ASSERT(globalUTF8Encoding.isValid());

+ DCHECK(globalUTF8Encoding.isValid());

return globalUTF8Encoding;

}