third_party/WebKit/Source/wtf/allocator/Partitions.cpp - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/allocator/Partitions.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/allocator/Partitions.cpp

diff --git a/third_party/WebKit/Source/wtf/allocator/Partitions.cpp b/third_party/WebKit/Source/wtf/allocator/Partitions.cpp

index 56d0a8f4af4131ddbebd2651ffac03abf4523d49..7b23382966265c537cac4ce1c0e1d886c7da5ffa 100644

--- a/third_party/WebKit/Source/wtf/allocator/Partitions.cpp

+++ b/third_party/WebKit/Source/wtf/allocator/Partitions.cpp

@@ -109,7 +109,7 @@ void Partitions::dumpMemoryStats(

base::PartitionStatsDumper* partitionStatsDumper) {

// Object model and rendering partitions are not thread safe and can be

// accessed only on the main thread.

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

decommitFreeableMemory();

partitionDumpStatsGeneric(fastMallocPartition(), "fast_malloc", isLightDump,