Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)
Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp
diff --git a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp
index d1cc2a19fc34444d47147db1d4a51501725071e5..c9d6777adb38cf11cece1a904c07cf5f5ccbcb5f 100644
--- a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp
+++ b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp
@@ -31,7 +31,7 @@
namespace WTF {
bool ArrayBuffer::transfer(ArrayBufferContents& result) {
- ASSERT(!isShared());
+ DCHECK(!isShared());
RefPtr<ArrayBuffer> keepAlive(this);
if (!m_contents.data()) {
@@ -66,7 +66,7 @@ bool ArrayBuffer::transfer(ArrayBufferContents& result) {
}
bool ArrayBuffer::shareContentsWith(ArrayBufferContents& result) {
- ASSERT(isShared());
+ DCHECK(isShared());
RefPtr<ArrayBuffer> keepAlive(this);
if (!m_contents.data()) {
@@ -88,7 +88,7 @@ void ArrayBuffer::addView(ArrayBufferView* view) {
}
void ArrayBuffer::removeView(ArrayBufferView* view) {
- ASSERT(this == view->m_buffer);
+ DCHECK_EQ(this, view->m_buffer.get());
if (view->m_nextView)
view->m_nextView->m_prevView = view->m_prevView;
if (view->m_prevView)

Powered by Google App Engine
This is Rietveld 408576698