third_party/WebKit/Source/wtf/HashCountedSet.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/HashCountedSet.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/HashCountedSet.h

diff --git a/third_party/WebKit/Source/wtf/HashCountedSet.h b/third_party/WebKit/Source/wtf/HashCountedSet.h

index 272fb9bc00ea70608dc24714c13d37f0654bcc63..1926967cc16b574bfd60639ca437f5bce3d27391 100644

--- a/third_party/WebKit/Source/wtf/HashCountedSet.h

+++ b/third_party/WebKit/Source/wtf/HashCountedSet.h

@@ -134,7 +134,7 @@ inline bool HashCountedSet<T, U, V, W>::remove(iterator it) {

return false;

unsigned oldVal = it->value;

- ASSERT(oldVal);

+ DCHECK(oldVal);

unsigned newVal = oldVal - 1;

if (newVal) {

it->value = newVal;