third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h

diff --git a/third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h b/third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h

index 16642d6337d848acf1e25482766d57356abef3a2..65bbb0ae0a2feb7ca2ab4007c47ccc79b3f651c9 100644

--- a/third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h

+++ b/third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h

@@ -50,14 +50,14 @@ class IntegerToStringConverter {

do {

--m_begin;

- ASSERT(m_begin != m_buffer);

+ DCHECK_NE(m_begin, m_buffer);

*m_begin = static_cast<LChar>((value % 10) + '0');

value /= 10;

} while (value);

if (isNegative) {

--m_begin;

- ASSERT(m_begin != m_buffer);

+ DCHECK_NE(m_begin, m_buffer);

*m_begin = static_cast<LChar>('-');

}