third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h

diff --git a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h

index d7c9e1f647e36c3bf78b27bd11592afb44998d9c..0a76b93d95a12851e813d4bbc74ce740dec6a759 100644

--- a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h

+++ b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h

@@ -128,7 +128,7 @@ class WTF_EXPORT ArrayBufferContents {

void checkIfAdjustAmountOfExternalAllocatedMemoryIsConsistent() {

DCHECK(s_adjustAmountOfExternalAllocatedMemoryFunction);

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

// Make sure that the function actually used is always the same.

// Shouldn't be updated during its use.

if (!s_lastUsedAdjustAmountOfExternalAllocatedMemoryFunction) {

@@ -148,7 +148,7 @@ class WTF_EXPORT ArrayBufferContents {

RefPtr<DataHolder> m_holder;

static AdjustAmountOfExternalAllocatedMemoryFunction

s_adjustAmountOfExternalAllocatedMemoryFunction;

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

static AdjustAmountOfExternalAllocatedMemoryFunction

s_lastUsedAdjustAmountOfExternalAllocatedMemoryFunction;

#endif