Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)
Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp
diff --git a/third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp b/third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp
index 77e69d9212977450b00157f1a52fd450d448ce53..386db70338a622e05a45ac63a99c149babd1a2e1 100644
--- a/third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp
+++ b/third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp
@@ -79,7 +79,7 @@ Collator::Result Collator::collate(const UChar* lhs,
}
void Collator::createCollator() const {
- ASSERT(!m_collator);
+ DCHECK(!m_collator);
UErrorCode status = U_ZERO_ERROR;
{
@@ -87,7 +87,7 @@ void Collator::createCollator() const {
if (cachedCollator) {
UColAttributeValue cachedCollatorLowerFirst =
ucol_getAttribute(cachedCollator, UCOL_CASE_FIRST, &status);
- ASSERT(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
if (0 == strcmp(cachedEquivalentLocale, m_equivalentLocale) &&
((UCOL_LOWER_FIRST == cachedCollatorLowerFirst && m_lowerFirst) ||
@@ -106,15 +106,15 @@ void Collator::createCollator() const {
m_collator =
ucol_open("", &status); // Fallback to Unicode Collation Algorithm.
}
- ASSERT(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
ucol_setAttribute(m_collator, UCOL_CASE_FIRST,
m_lowerFirst ? UCOL_LOWER_FIRST : UCOL_UPPER_FIRST,
&status);
- ASSERT(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
ucol_setAttribute(m_collator, UCOL_NORMALIZATION_MODE, UCOL_ON, &status);
- ASSERT(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
}
void Collator::releaseCollator() {
« no previous file with comments | « third_party/WebKit/Source/wtf/text/WTFString.cpp ('k') | third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698