third_party/WebKit/Source/wtf/HashMapTest.cpp - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/HashMapTest.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/HashMapTest.cpp

diff --git a/third_party/WebKit/Source/wtf/HashMapTest.cpp b/third_party/WebKit/Source/wtf/HashMapTest.cpp

index 7a6e32b6bb5a4f28df40d70d7e226c5a5d36860e..733fa73ebde6d80b5945552c1f6ab5e9e56196e2 100644

--- a/third_party/WebKit/Source/wtf/HashMapTest.cpp

+++ b/third_party/WebKit/Source/wtf/HashMapTest.cpp

@@ -141,18 +141,18 @@ class DummyRefCounted : public RefCounted<DummyRefCounted> {

m_isDeleted = false;

}

~DummyRefCounted() {

- ASSERT(!m_isDeleted);

+ DCHECK(!m_isDeleted);

m_isDeleted = true;

}

void ref() {

- ASSERT(!m_isDeleted);

+ DCHECK(!m_isDeleted);

WTF::RefCounted<DummyRefCounted>::ref();

++m_refInvokesCount;

}

void deref() {

- ASSERT(!m_isDeleted);

+ DCHECK(!m_isDeleted);

WTF::RefCounted<DummyRefCounted>::deref();

}