third_party/WebKit/Source/wtf/dtoa.cpp - Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/dtoa.cpp

Issue 2585673002: Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf (Closed)

Patch Set: Fix an Asan issue with LinkedHashSetNodeBase::unlink Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/dtoa.cpp

diff --git a/third_party/WebKit/Source/wtf/dtoa.cpp b/third_party/WebKit/Source/wtf/dtoa.cpp

index dc143e6982a30969a2b89065eaf0572241ee652f..a0f46f83069bf67d3c1d667db17405a135ff16e7 100644

--- a/third_party/WebKit/Source/wtf/dtoa.cpp

+++ b/third_party/WebKit/Source/wtf/dtoa.cpp

@@ -80,7 +80,7 @@ static inline const char* formatStringTruncatingTrailingZerosIfNeeded(

// If we removed all trailing zeros, remove the decimal point as well.

if (truncatedLength == decimalPointPosition) {

- ASSERT(truncatedLength > 0);

+ DCHECK_GT(truncatedLength, 0u);

--truncatedLength;

}