Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2480813003: Reduce views::Border creation verbosity by promoting factory functions (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org, Matt Giuca, sebsg+autofillwatch_chromium.org, raymes+watch_chromium.org, nona+watch_chromium.org, rouslan+bubble_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, derat+watch_chromium.org, rouslan+autofill_chromium.org, mlamouri+watch-notifications_chromium.org, dkrahn+watch_chromium.org, oshima+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, dbeam+watch-downloads_chromium.org, sync-reviews_chromium.org, awdf+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, groby+bubble_chromium.org, Peter Beverloo, mathp+autofillwatch_chromium.org, tfarina, shuchen+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce views::Border creation verbosity by promoting factory functions to standalone members of views::. BUG=none Committed: https://crrev.com/4272850df03a90e5260f34c682f3ff5248a1da44 Cr-Commit-Position: refs/heads/master@{#430379}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Patch Set 4 : fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -421 lines) Patch
M ash/common/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/audio/volume_view.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M ash/common/system/chromeos/network/network_list_md.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/network/vpn_list_view.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M ash/common/system/chromeos/palette/common_palette_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/session/logout_button_tray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/session/logout_confirmation_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/date/date_default_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/date/date_view.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/common/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/status_area_widget_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/toast/toast_overlay.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ash/common/system/tray/hover_highlight_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/label_tray_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/special_popup_row.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/common/system/tray/system_menu_button.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray_bubble.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_utils.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M ash/common/system/user/button_from_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/user/tray_user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/user/user_card_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/user/user_view.cc View 1 2 7 chunks +15 lines, -15 lines 0 comments Download
M ash/common/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/window_cycle_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/echo_dialog_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/save_card_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/intent_picker_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/message_center_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 8 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/subtle_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/views/folder_header_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_actions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_tile_item_list_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/chromeos/ime/candidate_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M ui/chromeos/ime/infolist_window.cc View 4 chunks +10 lines, -12 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 5 chunks +11 lines, -19 lines 0 comments Download
M ui/views/border.h View 1 2 3 3 chunks +50 lines, -51 lines 0 comments Download
M ui/views/border.cc View 1 2 1 chunk +21 lines, -32 lines 0 comments Download
M ui/views/border_unittest.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/image_button_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/vector_icon_button.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scroll_view_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/examples/label_example.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/multiline_example.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/text_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/vector_example.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Evan Stade
4 years, 1 month ago (2016-11-07 15:15:35 UTC) #6
sky
LGTM - I looked through the border changes and some of the rest. Mostly rubber ...
4 years, 1 month ago (2016-11-07 17:10:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480813003/60001
4 years, 1 month ago (2016-11-07 17:15:04 UTC) #14
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 1 month ago (2016-11-07 18:44:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480813003/60001
4 years, 1 month ago (2016-11-07 21:19:40 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-07 21:28:57 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 21:32:59 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4272850df03a90e5260f34c682f3ff5248a1da44
Cr-Commit-Position: refs/heads/master@{#430379}

Powered by Google App Engine
This is Rietveld 408576698